RecordBatch normalization (flattening)
#6758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngli-me
changed the title
ngli-me
changed the title
RecordBatch normalization (flattening)
… iterative function for `RecordBatch`. Not sure which one is better currently.
ngli-me
commented
Nov 23, 2024
There was a problem hiding this comment.
I had some questions regarding the implementation of this, since the one example from PyArrow doesn't seem to clarify on the edge cases here. Normalizing the Schema seems fairly straight forward to me, I'm just not sure on
- Whether the iterative or recursive approach is better (or something I missed)
- If
DataType::Structis the onlyDataTypethat requires flattening. To me, it looks like that's the only one that can contained nestedFields.
(I'm also not sure if I'm missing something with unwrapping like a List<Struct>)
Any feedback/help would be appreciated!
added 2 commits
November 23, 2024 21:03
ngli-me
commented
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6369.
Rationale for this change
Adds normalization (flattening) for
RecordBatch, with normalization viaSchema. Based on pandas/pola-rs.What changes are included in this PR?
Are there any user-facing changes?